search

google / earthenterprise

Google Earth Enterprise - Open Source
Apache License 2.0
2.67k stars 888 forks source link

opengee-extra RPM fails to register plugin on when using peer authentication #1854

Closed tst-sbayard closed 3 years ago

tst-sbayard commented 3 years ago

If peer authentication is configured for PostgreSQL, the ExampleSearch will not be registered properly if the *NIX user is not in the user map. This change runs the command as gepguser to ensure it executes properly.

tst-lsavoie commented 3 years ago

There's also code that modifies examplesearch in opengee-server/snippets/post-install.sh. You should fix that one too.

google-cla[bot] commented 3 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

tst-lsavoie commented 3 years ago

@googlebot I consent.

tst-lsavoie commented 3 years ago

Turns out I have permissions on your fork, so I made the change to the opengee-server script.

tst-sbayard commented 3 years ago

Well, I was testing the change locally before pushing, but there you go ;P

EDIT: Just for anyone reading, there was some confusion about whether I was working today. That's why @tst-lsavoie went ahead and pushed a commit.

google-cla[bot] commented 3 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

tst-lsavoie commented 3 years ago

@googlebot I consent.