Closed tst-mswartz closed 3 years ago
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.
We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent.
in this pull request.
Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla
label to yes
(if enabled on your project).
ℹ️ Googlers: Go here for more info.
does not crash, just have a question re: keeping the lines in with comment vs removing them
Commenting out the two connect() lines that cause the segfaults. They don't seem to be required for cleanup, and databases are pushed successfully to the server. It seems as though the push and publish threads are attempting to schedule themselves for deletion by themselves (?) but according to the Qt documentation it seems as though this should happen automatically when the dialog boxes are closed.