search

google / earthenterprise

Google Earth Enterprise - Open Source
Apache License 2.0
2.67k stars 888 forks source link

Qt4 button color for color pickers #1882

Closed tst-mswartz closed 3 years ago

tst-mswartz commented 3 years ago

Fix for color picker button in vector projects

google-cla[bot] commented 3 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

tst-mswartz commented 3 years ago

Now includes fixes for color pickers in map layers, thematic filters, and preferences. Note there is a current bug in thematic filters that causes a segfault but it persisted even after I rolled out my changes so I think it is unrelated.

tst-mswartz commented 3 years ago

Verification steps to test:

  1. "Edit" menu -> Preferences. You are able to see the default colors filling the boxes and can reset them to whatever you choose
  2. Vector Project -> Configure Display Rules. You are able to see the default "Line Color" filling the box and can modify it
  3. MapLayers: Line color, Shield fill and outline color can all be viewed and modified. Note that to be able to enable shields, you must first check "Draw As Roads"
  4. Vector Project -> Configure Display Rules -> Thematic Filters. You can see and modify the start and end colors. Note that closing this window might cause a segfault