google / earthenterprise

Google Earth Enterprise - Open Source
Apache License 2.0
2.67k stars 887 forks source link

Crash-causing OBOB fixed that resulted from faulty iterator logic #1898

Closed tst-sbayard closed 3 years ago

tst-sbayard commented 3 years ago

Title says it. In the upgrade to QT4, it looks like the value returned by *it after the last element is no longer zero as the original logic was assuming. The result was an attempt to delete one more item than was in the list.

Replaced with a simple for loop which also resulted in trimming down the code.