search

google / earthenterprise

Google Earth Enterprise - Open Source
Apache License 2.0
2.67k stars 887 forks source link

Remove publish root ownership change from RPM installer, add --nochown to geconfigurepublishroot #1917

Closed tst-jlarocco closed 3 years ago

tst-jlarocco commented 3 years ago

Fixes #1910

The RPM installer no longer changes ownership or permissions of the publish root. If the user needs to change publish root ownership they can do it after installation with geconfigurepublishroot.

For large publish roots, it's recommended to use geconfigurepublishroot --nochown ... unless the ownership and permissions need to be fixed.

tst-lsavoie commented 3 years ago

IIRC, @tst-ccamp had suggested making nochown the default and requiring users to pass a flag if they want to run the chown. What do you think about that? You'd need to make the same change to geconfigureassetroot.

Also, we should update the documentation with the new flag.

tst-jlarocco commented 3 years ago

IIRC, @tst-ccamp had suggested making nochown the default and requiring users to pass a flag if they want to run the chown. What do you think about that? You'd need to make the same change to geconfigureassetroot.

Also, we should update the documentation with the new flag.

Yeah, that makes sense because it's what people would want most of the time.

tst-lsavoie commented 3 years ago

I think the docs need to be rebuilt again.

As a side note, when I install Fusion or Server I get the 5.3.7 docs, so I don't see your changes. I don't think that has anything to do with this PR, though.

tst-lsavoie commented 3 years ago

I noticed that if the permissions on /gevol/assets are wrong we get duplicate warnings when installing Fusion:

WARNING: The installer detected the asset root may have incorrect permissions! After installation you may need to run 

sudo /opt/google/bin/geconfigureassetroot --noprompt --chown --repair --assetroot /gevol/assets

Switching to (gefusionuser, gegroup)
Setting up assetroot status object
Validating assetroot
No volume changes to save.
Configured /gevol/assets.
No upgrade needed.
Fusion Fatal:   
/gevol/assets needs to be repaired.
You must run the following command:
  geconfigureassetroot --repair --assetroot /gevol/assets

We could add --chown to the second command or just live with it.