search

google / earthenterprise

Google Earth Enterprise - Open Source
Apache License 2.0
2.67k stars 887 forks source link

Background color fix for jpgs in wms #1920

Closed tst-mswartz closed 3 years ago

tst-mswartz commented 3 years ago

Verification steps:

  1. Publish a globe with "wms" enabled in the admin panel
  2. Using qgis or a script, view the wms content.. In qgis try connecting using jpg
  3. Background is no longer black by default
google-cla[bot] commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

tst-mbiancalana commented 3 years ago

The merge of release_5.3.7.1 into this PR should be backed out (either by rebase or other means). That branch hasn't been merged into master yet (though it could be at any time), and it will be confusing to do that merge as part of this PR.

google-cla[bot] commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

tst-mbiancalana commented 3 years ago

@tst-mswartz I've looked at this again, and I'm not sure what I saw that made me think this needed the commits from release_5.3.7.1 removed. As you pointed out when we talked, the diff is just your changes. I'm marking that task as done (obsolete) and approving the PR. Sorry for the confusion.