search

google / earthenterprise

Google Earth Enterprise - Open Source
Apache License 2.0
2.66k stars 882 forks source link

added vector size check after calling TokenizeString #1944

Closed tst-mreinert closed 3 years ago

tst-mreinert commented 3 years ago

fixes #1943

Add calls to std::vector::size prior to accessing vector elements in JsonUtils.cpp and geaddtomapproject.cpp

tst-lsavoie commented 3 years ago

How difficult would it be to add unit tests for JsonUtils.cpp, or at least the part that you modified? I get that adding unit tests to geaddtomapproject.cpp is going to be a problem since it already has a main function, but it would be nice to add some tests where we can.