search

google / earthenterprise

Google Earth Enterprise - Open Source
Apache License 2.0
2.67k stars 890 forks source link

Upgrade jquery #1966

Closed iparanza closed 3 years ago

iparanza commented 3 years ago

Upgrading jquery to 3.6.0 for STIG and CVE issues.

Verification Steps:

tst-nfarah commented 3 years ago

Let's link in the description the ticket this PR address if one does not exist. If it does not let' create it.

tst-nfarah commented 3 years ago

Let's add verification steps for a reviewer/tester to follow.

iparanza commented 3 years ago

Should we version the used jquery.min.js and jquery.js in their name, that way we know what version they are/were ? (e.g: add version to the name of the .js files)

That might be out of scope for this PR. This was just to upgrade jquery. If we want to version it that's going to require more work to update all of the jquery references in the code base.

iparanza commented 3 years ago

Sorry found some more places in docs that used an old version of jquery. We also have several "versions" of the static fold for docs that seem to get moved depending on tag versions. I'm only updating the jquery file in the 5.3.8 geedocs folder.

iparanza commented 3 years ago

It's come to my understanding that docs are generated manually and pushed into the geedocs folder. The jquery version being packaged comes from using an old version of sphinx mentioned in the build docs readme. I'm going to back out the docs portion of this PR and submit another one to handle jquery in the docs.