search

google / earthenterprise

Google Earth Enterprise - Open Source
Apache License 2.0
2.67k stars 890 forks source link

run_tutorial.sh should use default asset root #961

Open tst-ccamp opened 6 years ago

tst-ccamp commented 6 years ago

The run_tutorial.sh script uses a non-standard asset root, requiring the user to change the asset root before running the script, which is tedious, unnecessary, and confusing. Since the script is often used for more than simply testing, it has caused some confusing issues because users do not expect the asset root path to be changed from its default /gevol/assets. The scripts are in earth_enterprise/src/fusion/tools/gee_test.

Acceptance Criteria:

  1. The run_tutorial.sh, run_historic.sh, status.sh, status_historical.sh, publish_tutorial.sh, and publish_historical.sh scripts should use the default asset root
  2. Update the README file to remove instructions telling users to change asset root

Stretch goals:

  1. Add an optional parameter to change the asset root path
  2. Add an optional parameter to change the publish root path
tst-lsavoie commented 6 years ago

@tst-ccamp we need to revisit this ticket. The scripts named above don't change the asset root - the user must do that before running them. That may turn this into a simple documentation change. We need to decide what we want the outcome of this ticket to be in light of this.

tst-ccamp commented 5 years ago

The asset root should be the default of /gevol/assets rather than /usr/local/google/gevol_test/assets

tst-lsavoie commented 5 years ago

We should update the README as well because it tells users to change the asset root.

tst-lsavoie commented 5 years ago

I'm not sure that stretch goal 3 makes sense because the script doesn't change the asset root, so there's nothing to change back.

tst-ccamp commented 5 years ago

@tst-lsavoie I've accepted your suggestions