search

google / easypki

Creating a certificate authority the easy way
Apache License 2.0
587 stars 108 forks source link

Use of hardlinks #9

Open liljenstolpe opened 6 years ago

liljenstolpe commented 6 years ago

Greetings,

We like to keep our pki offline. Given that some folks are Linux, and others are Mac, the best format to use (most unfortunately) is FAT32. That has a problem with hard-links. Do we really need to store things both within the hierarchy and flat? If not, we could have an option to make the hard-links or not, but then we need to look in the same place for files (right now, if the hardlink fails, you can't read the signing key, for example).

If not, could we make a copy rather than a hardlink (yes, wasteful, I know, but we are talking about small bits of data).

Thoughts?

jeremy-clerc commented 6 years ago

Sorry for the very late reply, I do not maintain this repo and I am not part of the org anymore, so I do not have write access to this repo.

So I looked at the code, and yes you could definitely copy them, or just write them twice. They are never supposed to change anyway. It should have occurred to me during the dev that the FS may not support hardlink.

So if you want this change, you will have to fork this repo and update pkg/store/local.go writeBundle, as I do not have access to this repo anymore I won't be able to integrate any change.