google / eddystone

Specification for Eddystone, an open beacon format from Google
Apache License 2.0
3.08k stars 760 forks source link

Remove GeneralDiscoverable flag #150

Open Timmmm opened 8 years ago

Timmmm commented 8 years ago

According to the BLE spec (Volume 3, Part C, Section 9.1.1.2), the GeneralDiscoverable flag shouldn't be set for Broadcast devices (which Eddystone should apparently be, when in beacon-advertising mode).

As far as I can tell, this is just used for filtering scan results on the host. I've tested it on Android and iOS and it still works.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


Timmmm commented 8 years ago

I have signed it.

zonestc commented 7 years ago

Good