search

google / eddystone

Specification for Eddystone, an open beacon format from Google
Apache License 2.0
3.08k stars 760 forks source link

optparse deprecated since version 2.7 #155

Closed PrabhanshuAttri closed 8 years ago

PrabhanshuAttri commented 8 years ago

optparse used in linux implementation of Eddystone URL is deprecated. Python3 uses argparse now. Can I take this issue and fix it?

scottjenson commented 8 years ago

Please do. But just to be clear, which implementation are you talking about?

PrabhanshuAttri commented 8 years ago

All the scripts under eddystone-url/implementations/linux/ use optparse. Thanks @scottjenson

tolson2000 commented 8 years ago

Can you include a test for Python version for those not using 3.x

On 06/18/2016 01:49 PM, Prabhanshu Attri wrote:

All the scripts under eddystone-url/implementations/linux/ use optparse. Thanks @scottjenson https://github.com/scottjenson

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/google/eddystone/issues/155#issuecomment-226961556, or mute the thread https://github.com/notifications/unsubscribe/AIrlX0WCmjHgyiUVzgLrlhWuzi8dHQvRks5qNEvQgaJpZM4I5BLF.

PrabhanshuAttri commented 8 years ago

@tolson2000 positively

PrabhanshuAttri commented 8 years ago

Hey @tolson2000 I just found out that argparse is compatible with python 2.x as it is based on optparse. Python Docs

tolson2000 commented 8 years ago

OK, cool. No need to test for it then.

On 06/18/2016 03:04 PM, Prabhanshu Attri wrote:

Hey @tolson2000 https://github.com/tolson2000 I just found out that argparse is compatible with python 2.x as it is based on optparse. Python Docs https://docs.python.org/2/howto/argparse.html

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/google/eddystone/issues/155#issuecomment-226964766, or mute the thread https://github.com/notifications/unsubscribe/AIrlX_UhK-0_8LA5zh-5lm6bRCxmBpagks5qNF10gaJpZM4I5BLF.

PrabhanshuAttri commented 8 years ago

Hi @tolson2000 just to let you know, these scripts were written in python3 only as subprocess calls are supported in python 3. I think the developer might be facing issues with os.call.