google / eddystone

Specification for Eddystone, an open beacon format from Google
Apache License 2.0
3.08k stars 762 forks source link

Proper naming of ECDH function #199

Open hakonfam opened 7 years ago

hakonfam commented 7 years ago

There are two issues:

Currently it is not easy to see what ECDH algorithm is used for Eddystone. As far as I can see, the only place it is described is in the "Notes" section of the "Eddystone Configuration Service" definition.

This exception exists because the reference design for eliptic curve-25519, which has been widely adopted, was implemented using little-endian arithmetic and is the basis for the EID design. Note: the elliptic curve-25519 reference design is little-endian, even though big-endian is used almost universally for all other >cryptographic protocols.

I propose that the name of the ECDH function is stated in the description of the "Public ECDH Key" characteristic in addition to where it is stated now.

Also, as the author of the ECDH function wants a different name to be used when describing the ECDH function, it might be smart to mention both names.