Negative temperature values not valid in TLM frame?

google / eddystone

Specification for Eddystone, an open beacon format from Google

Apache License 2.0

3.08k stars 760 forks source link

Negative temperature values not valid in TLM frame? #64

Open irgu opened 9 years ago

irgu commented 9 years ago

There is no info in specification that negative values are not valid for TLM frames, so I think it would be logic to expand range in Eddystone Validator app(now it's 0 to 60 degrees Celsius).

kimusan commented 9 years ago

I agree. Negative value temperatures should is supported according to the spec (As I read it at least) so the validator should reflect this. Only "problem" is that there is not really any dest for invalid values except if it is -128.0f (as it is really the only invalid value in the accepted range (127.0f to 128.0f).

kimusan commented 9 years ago

https://github.com/google/eddystone/pull/67