search

google / effcee

Effcee is a C++ library for stateful pattern matching of strings, inspired by LLVM's FileCheck
Apache License 2.0
93 stars 39 forks source link

Stop forcing c++11 because of re2 #47

Closed jeremyg-lunarg closed 1 year ago

jeremyg-lunarg commented 1 year ago

Setting -std=c++11 is forcing projects using effcee to use exactly this version of the standard. Some of these projects, such as SPIRV-Tools now require c++17.

dneto0 commented 1 year ago

Hmm. Isn't there another problem in that the top level CMakeLists.txt file sets required C++ version at 11? https://github.com/google/effcee/blob/main/CMakeLists.txt#L5

SPIRV-Tools had that problem, which was resolved with https://github.com/KhronosGroup/SPIRV-Tools/pull/5020/files But now I see even that has advice that it should be solved with target properties, at least for libraries. ?

dneto0 commented 1 year ago

I think https://github.com/google/effcee/pull/48 should fix this in a better way. Please verify.

jeremyg-lunarg commented 1 year ago

Yep. #48 fixes it for me. Thanks!