search

google / elemental2

Type checked access to browser APIs for Java code.
Apache License 2.0
150 stars 38 forks source link

Use the same version of closure-compiler that rules_closure provides #138

Closed niloc132 closed 4 years ago

niloc132 commented 4 years ago

This patch backs out the currently broken commit d15d513, which assumed that a extern() rule would see changes made on master of closure-compiler. However, only the alias() rules currently point to master of that repo - the extern() rules all point to the externs.zip in the closure-compiler that rules_closure provides, tagged in git as v20200112 (see https://github.com/bazelbuild/rules_closure/blob/master/closure/repositories.bzl#L657).

However, the tagged artifact is the "unshaded" jar, and while it contains externs.zip, that zip does not contain the contrib/externs/ directory, so both svg and webassembly, which were still in that directory as of 2020-01-12, must be referenced from the git repo directly, This is why I left the http_archive for closure, but just changed it to point at the specified tag.

If you decide to merge this, it might make sense to do it in two pieces so that the "revert" commit can be re-reverted. When J2cl's "io_bazel_rules_closure" rule is updated, the tagged closure-compiler here will have to be updated too.

jDramaix commented 4 years ago

Let's update the closure compiler to the newest release in closure build rule. That should solve the issue.

jDramaix commented 4 years ago

See https://github.com/bazelbuild/rules_closure/pull/482