search

google / elemental2

Type checked access to browser APIs for Java code.
Apache License 2.0
150 stars 38 forks source link

New release of elemental2 #159

Closed treblereel closed 1 year ago

treblereel commented 1 year ago

Hello team,

Elemental2 maven artifacts have been released about 3 years ago, maybe you can release 1.2.0?

Thanks!

gkdn commented 1 year ago

We will do a new release soon.

treblereel commented 1 year ago

@gkdn sounds great! Very cool!

zbynek commented 1 year ago

@gkdn when do you expect to do the release?

gkdn commented 1 year ago

Our plan is to do it next week.

gkdn commented 1 year ago

@mason-lgtm just released 1.2.0. Could you take a look and let us know if it is working?

aeromac commented 1 year ago

I'm getting:

[ERROR] Errors in 'elemental2/core/BigUint64Array.java' [INFO] [ERROR] Line 24: The import jsinterop.base.JsBigint cannot be resolved [INFO] [ERROR] Line 51: JsBigint cannot be resolved to a type

zbynek commented 1 year ago

cannot access elemental2.core.JsRegExp class file has wrong version 55.0, should be 52.0

@gkdn did you intentionally increase the min Java level from 8 to 11?

zbynek commented 1 year ago

@aeromac to fix that you can add com.google.jsinterop:base:1.0.1 to your dependencies

gkdn commented 1 year ago

Looks like we didn't give a good version number to jsinterop-base; I wonder if that can cause problems with Maven 🤔

@zbynek Yes, we stopped supporting Java 8.

mason-lgtm commented 1 year ago

@aeromac, I fixed the dependency with elemental2 1.2.1. Please check again when you get the chance?

adrian-haenni commented 1 year ago

@mason-lgtm Version 1.2.1 does not work, I get:


[INFO]       [ERROR] Errors in 'jar:file:../.m2/repository/com/google/elemental2/elemental2-core/1.2.1/elemental2-core-1.2.1.jar!/elemental2/core/BigInt64Array.java'
[INFO]          [ERROR] Line 24: The import jsinterop.base.JsBigint cannot be resolved
[INFO]          [ERROR] Line 230: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 232: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 51: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 105: The method cast(Object) from the type Js refers to the missing type JsBigint
[INFO]          [ERROR] Line 150: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 99: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 176: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 196: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 149: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 155: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 171: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 154: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 234: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 132: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 88: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 226: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 104: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 228: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 160: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 138: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 100: The method cast(Object) from the type Js refers to the missing type JsBigint
[INFO]          [ERROR] Line 159: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 165: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 52: The method cast(Object) from the type Js refers to the missing type JsBigint
[INFO]          [ERROR] Line 224: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 143: JsBigint cannot be resolved to a type
[INFO]    Tracing compile failure path for type 'elemental2.core.BigUint64Array'
[INFO]       [ERROR] Errors in 'jar:file:../.m2/repository/com/google/elemental2/elemental2-core/1.2.1/elemental2-core-1.2.1.jar!/elemental2/core/BigUint64Array.java'
[INFO]          [ERROR] Line 24: The import jsinterop.base.JsBigint cannot be resolved
[INFO]          [ERROR] Line 51: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 105: The method cast(Object) from the type Js refers to the missing type JsBigint
[INFO]          [ERROR] Line 231: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 150: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 99: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 176: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 196: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 149: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 155: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 171: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 235: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 154: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 233: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 132: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 88: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 225: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 104: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 160: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 229: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 227: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 138: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 100: The method cast(Object) from the type Js refers to the missing type JsBigint
[INFO]          [ERROR] Line 159: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 165: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 52: The method cast(Object) from the type Js refers to the missing type JsBigint
[INFO]          [ERROR] Line 143: JsBigint cannot be resolved to a type
[INFO]    Tracing compile failure path for type 'elemental2.core.DataView'
[INFO]       [ERROR] Errors in 'jar:file:../.m2/repository/com/google/elemental2/elemental2-core/1.2.1/elemental2-core-1.2.1.jar!/elemental2/core/DataView.java'
[INFO]          [ERROR] Line 76: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 78: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 108: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 72: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 114: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 112: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 110: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 22: The import jsinterop.base.JsBigint cannot be resolved
[INFO]          [ERROR] Line 74: JsBigint cannot be resolved to a type
[INFO]    Tracing compile failure path for type 'elemental2.core.BigInt'
[INFO]       [ERROR] Errors in 'jar:file:../.m2/repository/com/google/elemental2/elemental2-core/1.2.1/elemental2-core-1.2.1.jar!/elemental2/core/BigInt.java'
[INFO]          [ERROR] Line 94: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 165: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 88: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 41: The method cast(Object) from the type Js refers to the missing type JsBigint
[INFO]          [ERROR] Line 23: The import jsinterop.base.JsBigint cannot be resolved
[INFO]          [ERROR] Line 40: JsBigint cannot be resolved to a type
[INFO]          [ERROR] Line 90: JsBigint cannot be resolved to a type
[INFO]    [ERROR] Aborting compile due to errors in some input files
``
niloc132 commented 1 year ago

@adrian-haenni can you share your pom, or the results of mvn dependency:tree -Dverbose, at least the parts that apply to elemental2 and jsinterop? I suspect your own project explicitly depends on com.google.jsinterop:base:1.0.0 rather than 1.0.1, which means these this new JsBigint type is missing.

adrian-haenni commented 1 year ago

@niloc132

Thanks Colin for the hint, I had indeed some outdated libraries in the maven config (org.pepstock:charba:jar:3.3 and org.jresearch.gwtproject.i18n:gwt-datetimeformat:jar:1.1.4) that have com.google.jsinterop:base:jar:1.0.0 as dependency. I could made it run with newer versions and maven exclusions.

gkdn commented 1 year ago

Looks like the new release is working, I'm closing the issue.

zbynek commented 5 months ago

@gkdn is there a timeline for 1.3.0 release?

treblereel commented 5 months ago

@zbynek lets wait for https://github.com/google/elemental2/pull/164

aeromac commented 4 months ago

any chance of getting ResizeObserver added to the release? 🤞

treblereel commented 4 months ago

@aeromac lets ask @gkdn. fwiv it's supported by all modern browsers (https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver), but it's wicg in closure. In case he approves your request, I can do a PR.

aeromac commented 4 months ago

that's great! thank you @treblereel :)

gkdn commented 4 months ago

@aeromac lets ask @gkdn. fwiv it's supported by all modern browsers (https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver), but it's wicg in closure. In case he approves your request, I can do a PR.

Sounds reasonable. @jDramaix any concerns?