google / elemental2

Type checked access to browser APIs for Java code.
Apache License 2.0
150 stars 38 forks source link

Add whatwg_encoding.js #166

Closed niloc132 closed 4 weeks ago

niloc132 commented 4 months ago

This provides tools to convert js strings to and from streams and typed arrays.

Well supported in all browsers, this could be part of elemental2-core, or it could reasonably be a (very very small) new elemental2-encoding jar. I can write a patch either way, if you'd like.

gkdn commented 2 months ago

@jDramaix @mollyibot

mollyibot commented 2 months ago

I add it under dom, looks like it is dependent on streamsapi.js

jDramaix commented 2 months ago

I'm not sure if elemental2-dom is the right place to put this file. It's not related to dom manipulation. I agree that elemental2-dom already contains several API that is not dom related but we could maybe clean that up. Let's discuss that in our next team meeting.

zbynek commented 4 weeks ago

Fixed in https://github.com/google/elemental2/commit/b0f4a54f9f1b450984f75e315b13b70fe0b83bf8 (part of 1.2.3). Issue can be closed.