google / eleventy-high-performance-blog

A high performance blog template for the 11ty static site generator.
https://www.industrialempathy.com/posts/eleventy-high-performance-blog/
MIT License
4.03k stars 283 forks source link

Remove Browsersync for Eleventy v2.x compatibility #182

Closed pkvach closed 10 months ago

pkvach commented 10 months ago

A compatibility issue with Eleventy v2.x came up after a recent merge request "Bump axios and @11ty/eleventy #180". It updated Eleventy from 1.0.0 to 2.0.1 https://github.com/google/eleventy-high-performance-blog/actions/runs/6827178225/job/18568727206

In Eleventy v2 Eleventy Dev Server replaces Browsersync (https://github.com/11ty/eleventy/issues/1305).

So I removed the Browsersync related code. Eleventy Dev Server has built-in support for 404.html. And there is no need for additional CSP code.

google-cla[bot] commented 10 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

cramforce commented 10 months ago

Is that gonna work with 11ty 1.0?

pkvach commented 10 months ago

This won't work for Eleventy v1.0 because Eleventy Dev Server was added in v2.0 https://www.11ty.dev/blog/eleventy-v2/#plugins

cramforce commented 10 months ago

Should we update the package.json dependency on 11ty?

pkvach commented 10 months ago

I noticed that the 11ty version has already been updated in the package.json file in pull request #180. The update has already been merged, but the build failed: https://github.com/google/eleventy-high-performance-blog/actions/runs/6827178225/job/18568727206

cramforce commented 10 months ago

OK, let's get this merged. I lost the ability to configure CI when I left Google, so stuff needs to be validated on a fork.

pkvach commented 10 months ago

Sure, I've already checked these changes. Thank you.