search

google / emboss

Emboss is a tool for generating code that reads and writes binary data structures.
Apache License 2.0
70 stars 21 forks source link

Use bzlmod to manage dependencies #163

Closed tpudlik closed 5 days ago

tpudlik commented 1 month ago

This will also make it easier to maintain emboss in the BCR (https://github.com/bazelbuild/bazel-central-registry/tree/main/modules/emboss).

Ideally we'd also set the version field of module, but the version value is unknown until the release workflow actually runs (because it encodes the release timestamp). In practice we should probably change the versioning scheme to pull the version number from MODULE.bazel, but I imagine that requires some discussion.

jasongraffius commented 1 month ago

I'm not too familiar with Bazel modules. Will this change affect anyone users of Emboss that are using Bazel? I suspect not, since this seems to just affect the equivalent of WORKSPACE (?), but I would want to confirm that.

tpudlik commented 1 month ago

That's right, existing Bazel projects that pull in Emboss through their WORKSPACE will not be affected.

tpudlik commented 5 days ago

Any blockers to merging this?