search

google / emboss

Emboss is a tool for generating code that reads and writes binary data structures.
Apache License 2.0
70 stars 21 forks source link

Explicitly downcast in emboss_text_util.h #52

Closed acsaeed closed 2 years ago

acsaeed commented 2 years ago

The line in question generates a compilation failure in Fuchsia, "error: implicit conversion loses integer precision: int to ::std::uint8_t" due to the "-Wimplicit-int-conversion" diagnostic flag. Adding an explicit static_cast here allows compilation.

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.