google / end-to-end

End-To-End is a crypto library to encrypt, decrypt, digital sign, and verify signed messages (implementing OpenPGP)
Apache License 2.0
4.13k stars 298 forks source link

compile warnings in welcome.js: Property isKeyRingEncrypted never defined on pgpCtx #148

Closed koto closed 9 years ago

koto commented 9 years ago

From adhintz@google.com on July 12, 2014 04:20:01

Building the extension I see the following warnings:

extension/ui/welcome/welcome.js:194: WARNING - Property isKeyRingEncrypted never defined on pgpCtx
if (pgpCtx.isKeyRingEncrypted()) {
^

extension/ui/welcome/welcome.js:248: WARNING - Property changeKeyRingPassphrase never defined on pgpCtx
pgpCtx.changeKeyRingPassphrase(passphrase);
^

extension/ui/welcome/welcome.js:260: WARNING - Property isKeyRingEncrypted never defined on pgpCtx
this.keyringMgmt_.setKeyringEncrypted(pgpCtx.isKeyRingEncrypted());

Original issue: http://code.google.com/p/end-to-end/issues/detail?id=111

koto commented 9 years ago

From koto@google.com on July 16, 2014 08:04:08

Owner: koto@google.com

koto commented 9 years ago

From koto@google.com on July 17, 2014 07:10:11

Status: FixedInStaging

koto commented 9 years ago

From evn@google.com on July 21, 2014 17:06:17

Labels: Type-Defect Priority-Medium Component-Logic Security

koto commented 9 years ago

From evn@google.com on July 23, 2014 11:25:29

This issue should be fixed in head.

If it's still a problem, please open a new bug.

Status: Fixed
Labels: Restrict-AddIssueComment-CoreTeam