search

google / eng-practices

Google's Engineering Practices documentation
https://google.github.io/eng-practices/
Other
20.03k stars 1.95k forks source link

Add acceptance criteria validation in functionality section to improve code review performance #62

Open kayevo opened 3 months ago

kayevo commented 3 months ago

This modification can improve the performance in the code review process for the developer's team.

The documentation talks that its hard to understand how some changes will impact a user just reading the code. However, just the UI changes are mentioned. Actually, the acceptance criteria and business necessity also cannot be validated just by reading the code.

I wrote an article on Linkedin about it right here: Article about testing code before code review analysis

Testing before the coding review flow: fac_1

Testing after the coding review flow: common_1

The results: results_1