Closed appsforartists closed 8 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
CLAs look good, thanks!
This LGTM in the spirit of aligning this with the expectations of our language team. cc @sindresorhus as an FYI.
The only guidance I can find on curly brace requirements in the JS style guide defers to the C++ style guide:
Therefore,
allowSingleLine
should betrue
. This modules parent (xo
) sets it tofalse
. Hence, I've added an override here that is identical to what's inxo
, except for thetrue
.