[added] no-unused-vars: args:none

[appsforartists]

This is another case where @sindresorhus appears to be more opinionated than Google is. Moreover, there are valid reasons that you may have unused arguments in a function, such as:

• To make it clear that the function is compatible with a particular API, like Event Listening:

  function onClick(event) {}

• To prevent future contributors from adding arguments that are incompatible with that signature

  function toggleValue(event) {}

  Even if the above event is unused, its presence reminds developers not to use the first argument position, as this function may be used as an event listener elsewhere.

• Because an API has changed and a parameter is no longer used, but you don't want to change the signature to avoid breaking people downstream.

Therefore, I'm disabling the no-unused-vars check on arguments.

[sindresorhus]

@appsforartists Are there any official docs about this convention? A lot of non-Googler are using this preset too, so would be nice to refer them to something.

[appsforartists]

@sindresorhus

Most of the changes I'm making are on things where there doesn't seem to be an established internal edict. If I find comments about any of it, of course, I'll post them here.

[sindresorhus]

Maybe document what the preset is not opinionated about so users can set those rules themselves? For example, the curly rule is something that most users would want to enforce (regardless of its value).

[sindresorhus]

The change itself looks good to me though. @addyosmani ?

[addyosmani]

Changes here LGTM

[appsforartists]

Thanks guys. Somebody want to press the Merge button? 😉

@sindresorhus Documenting intentionally unset style choices is an interesting idea, but honestly it's not high on my priority list. Perhaps people who want something more strict than Google should try xo. 😄

[sindresorhus]

People want the Google preset because Google.

I'll document this later.

[appsforartists]

Thanks.