search

google / eslint-config-google

ESLint shareable config for the Google JavaScript style guide
Apache License 2.0
1.74k stars 140 forks source link

Remove dependency on xo #18

Closed appsforartists closed 7 years ago

appsforartists commented 8 years ago

xo is much more opinionated than our Style Guide.

I'm using this eslint config to write Google code, and I keep running into xo's opinions on things that are either undefined or encouraged by our internal guide. One of these days, I'm going to just read our internal guide and write a proper eslint config for it that doesn't inherit from anybody else's. That gives us immunity, both now and as both configs evolve over time.

appsforartists commented 8 years ago

Consider adding comments to each rule that cite where it is in the guide/why that rule applies.

dongbohu commented 7 years ago

Seems that you have already removed the dependency on xo. Can you also update the npm module? Thanks.

appsforartists commented 7 years ago

Closed by #23.