Publish new release with support for updated style guide

google / eslint-config-google

ESLint shareable config for the Google JavaScript style guide

Apache License 2.0

1.75k stars 139 forks source link

Publish new release with support for updated style guide #24

Open addyosmani opened 8 years ago

addyosmani commented 8 years ago

[x] Add support for new style guide to master
[x] Test master with Google OSS projects (e.g sw-toolbox) that use the style guide to determine state of breakage, if any. What else might be useful to capture in the changelog notes
[ ] Tag new major release and publish to npm

cc @philipwalton @gauntface as an fyi

philipwalton commented 8 years ago

I updated a few projects I work on with the new style guide and found three major areas of breakage:

1) comma-dangle: New styles require trailing commas in arrays and object definition blocks. Many of our OSS projects do not do this.

2) arrow-parens: The styleguide recommends using parens around single-argument arrow functions. Several of the projects I've seen extending this config include rules that actually require no parens in those cases. This may not cause breakage (if the rule is an override), but we should be consistent.

3) no-invalid-this: I don't think this is a change for the previous Google style guide, closure compiler has always been pretty strict about where you could use this for optimization reasons.

gauntface commented 8 years ago

Is say make it a major release and don't worry about the breakage. If it's best practice / style then go with it.

BrockWills commented 8 years ago

Is there any way to view the new styleguide? The style guide linked in the readme is no longer accurate with these changes

addyosmani commented 8 years ago

It hasn't been published outside of Google just yet. We're working on it but it's going to take a bit :)

appsforartists commented 8 years ago

CC @dongbohu

gauntface commented 8 years ago

Worth updating the readme to hint at using the eslint:recommended config as well as Google?

Found a few things that were nice to have from eslint:recommnded - forced env + ecmascript config.

addyosmani commented 8 years ago

I think so. Could you file an issue and we can get that tackled? On Tue, Oct 18, 2016 at 7:16 PM Matt Gaunt notifications@github.com wrote:

Worth updating the readme to hint at using the eslint:recommended config as well as Google?

Found a few things that were nice to have from eslint:recommnded - forced env + ecmascript config.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google/eslint-config-google/issues/24#issuecomment-254692088, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGxaUijiOL73qPTpYT8wrwqSSRMLBXmks5q1X1lgaJpZM4KHHen .

philipwalton commented 8 years ago

Created #27. I'll send a PR for this shortly.

ilyaigpetrov commented 7 years ago

0.7.1 was published on NPM. Please, update url of "Google JavaScript style guide" in README.md @addyosmani and all the team, thank you.

goatandsheep commented 5 years ago

New style guide published publicly!