google / eslint-config-google

ESLint shareable config for the Google JavaScript style guide
Apache License 2.0
1.74k stars 140 forks source link

Does this config support for eslint 6.1.0 (lastest version)? #57

Closed DemonCloud closed 5 years ago

DemonCloud commented 5 years ago

I was update Eslint to 6.1.0 version

Screen Shot 2019-07-31 at 4 28 48 PM

my .eslintrc.js in $HOME dir, work fine at Eslint 5.0.0 version

module.exports = {
  env: {
    browser: true,
    commonjs: true,
    es6: true,
    node: true,
  },
  parser: 'babel-eslint',
  plugins: ['react'],
  extends: [
    'eslint:recommended',
    'google',
    'plugin:react/recommended',
    'prefer-object-spread',
  ],
  globals: {
    wx: null,
    App: null,
    Page: null,
    getApp: null,
    Component: null,
  },
  parserOptions: {
    ecmaFeatures: {
      jsx: true,
    },
    ecmaVersion: 2017,
    sourceType: 'module',
  },
  rules: {
    'prefer-object-spread/prefer-object-spread': 2,
  }
};
philipwalton commented 5 years ago

I'm using this config with eslint 6.1.0 and it works for me. I suspect there's something else going on here that's causing issues fro you. I'm going to close this issue, but feel free to reply if you discover some other reason that it's not working properly.

DemonCloud commented 5 years ago

@philipwalton OK