search

google / eslint-config-google

ESLint shareable config for the Google JavaScript style guide
Apache License 2.0
1.74k stars 140 forks source link

Make it compatible with typescript-eslint #62

Open IGassmann opened 5 years ago

IGassmann commented 5 years ago

Make eslint-config-google rules compatible with the TSLint replacement: typescript-eslint.

This will be valuable for TypeScript projects that follow the Google JavaScript Style Guide, such as Angular.

Pringmore commented 4 years ago

Hi @IGassmann

are there some news about configuring typescript-eslint:recommanded with eslint-config-google ?

IGassmann commented 4 years ago

@Pringmore I wouldn't know. I'm not personally taking this initiative.

loeffel-io commented 4 years ago

+1

43081j commented 4 years ago

If you extend both the recommend config and the eslint recommended config, it seems to work for me:

  "extends": [
    "google",
    "plugin:@typescript-eslint/eslint-recommended",
    "plugin:@typescript-eslint/recommended"
  ],

eslint-recommended disables a bunch of non-typescript rules which conflict with typescript equivalents.

devinrhode2 commented 3 years ago

I think doing this is a great interim strategy:

  "extends": [
    "google",
    "plugin:@typescript-eslint/eslint-recommended",
    "plugin:@typescript-eslint/recommended"
  ],

But, it's quite un-satisfying, if you are a real TypeScript Junkie/fanboy/lover person. Maybe folks would be better off trying to use Angular core's config somehow, or using another eslint config altogether.