search

google / eslint-config-google

ESLint shareable config for the Google JavaScript style guide
Apache License 2.0
1.75k stars 139 forks source link

Reflect latest eslint-config-xo #9

Closed calvinkarundu closed 8 years ago

calvinkarundu commented 8 years ago

Extended xo config doesn't download the latest version of the main eslint-config-xo repo. Still includes deprecated rules in eslint ^2.0.0 Maybe it's not compatible? package.json reads "eslint-config-xo": "^0.7.0"

benderTheCrime commented 8 years ago

I'm not exactly sure if this is related because I don't fully understand the extent of the above comment, but the latest version of this package uses eslint-config-xo@^0.10.1, which does not cover eslint-config-xo@0.11.0.That version (eslint-config-xo@^0.10.1) does indeed have rules deprecated in eslint@^2.0.0, such as "no-empty-labels".

calvinkarundu commented 8 years ago

The inclusion of the deprecated rules is what I was pointing out. I'm forced to overwrite those rules after extending the google config so as to stop the linter from throwing errors. If you're aware though, that's fine; I just found it a bit redundant to disable deprecated rules when they shouldn't be there in the first place.

benderTheCrime commented 8 years ago

Ok, yeah I did the same thing. Nevertheless annoying to have to balloon out my own config file to account for deprecated rules.

:+1:

addyosmani commented 8 years ago

I agree we should probably clean this up. PR welcome if we need this sooner otherwise we'll try tackling this later on the week.

sindresorhus commented 8 years ago

All the ESLint 2 changes was part of eslint-config-xo@0.10.0 (which this package depends on), so I have no idea what's requested here.

calvinkarundu commented 8 years ago

My package.json read "eslint-config-google": "^0.3.0" and not "^0.4.0". Bumped up the version number and everything looks good :+1: