search

google / etc2comp

Apache License 2.0
378 stars 122 forks source link

Not all mipmap levels are generated for non-square images #31

Open dherben opened 6 years ago

dherben commented 6 years ago

I'm using EtcTool to compress rectangular, power of 2 images (2048x1024) with mipmaps for use in WebGL. WebGL Refuses to load the textures when one of the mipmap-based minFilters is selected.

The generated KTX file contains mipmaps from 2048x1024 down to 2x1. WebGL seems to require a 1x1 mipmap.

I've changed this in my fork and the textures now load correctly. The changes are trivial. If there's any interest, I can try to create a pull request, although my open source contribution skills are rusty

suikki commented 6 years ago

There is already a pull request for this (https://github.com/google/etc2comp/pull/29), but there hasn't been any activity on this project for some time so don't hold your breath.

dherben commented 6 years ago

Thanks, I missed that one. I'll just keep using my fork, then

rtissera commented 5 years ago

Bumping this one, merging the PR #29 would save people from maintaining forks.