allow training of non-jax tasks

google / evojax

Apache License 2.0

826 stars 78 forks source link

Closed lerrytang closed 2 years ago

alantian commented 2 years ago

LGTM overall.

A few minor missing pieces that could be added before merging @lerrytang :

Add procgen to extras_require in main/setup.py
Add testing initialisation of the newly added procgen task in tests/test_init_extra.py (it's in *_extra.py since this task has on the optional dependency.
Make sure all tests are passed.

lerrytang commented 2 years ago

Thanks for the review, issues addressed.

alantian commented 2 years ago

LGTM