google / evojax

Apache License 2.0
826 stars 78 forks source link

fix bug for non-ant brax envs failing #39

Closed Surya-77 closed 2 years ago

Surya-77 commented 2 years ago

Summary

Pull request to fix bug outlined in #38 Please let me know if you have any concerns relating to this PR.

Fixes

As outlined in #38 , the fix isolates code between the map-elites specific changes versus the other algorithms in evojax/task/brax_task.py Created a seperate TaskState dataclass to handle additional arguments required for map-elites. Mostly revert general functionality to precommit of #33

Tests

Tested on examples/train_ant_map_elites.py Tested on 'scripts/benchmarks/train.py' with PGPE algorithm and a modified config file included in PR. Not tested on other algorithms.

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

lerrytang commented 2 years ago

Thanks for the contribution!

Extra tests: