AssertionError for OpenES

google / evojax

Apache License 2.0

826 stars 78 forks source link

AssertionError for OpenES #56

Closed pigozzif closed 1 year ago

pigozzif commented 1 year ago

When I try to instantiate OpenES from open_es.py, I get the following error message:

I traced back the problem to line 110 in open_es.py, where both centered_rank and z_score arguments are set to True:

But line 26 of FitnessShaper class from evosax/utils/reshape_fitness.py says that

How to get around this issue?

lerrytang commented 1 year ago

@RobertTLange Do you mind taking a look at this issue?

RobertTLange commented 1 year ago

Should be fixed in PR #57. Sorry for the hick-up!

lerrytang commented 1 year ago

@RobertTLange Thanks for the fix! @pigozzif I've merged the PR, can you confirm it fixes your problem?

pigozzif commented 1 year ago

Dear all, the PR fixes my problem. Thank you very much for the support! Best regards,

Federico Pigozzi

On Wed, 21 Dec 2022 at 05:50, Yujin Tang @.***> wrote:

@RobertTLange https://github.com/RobertTLange Thanks for the fix! @pigozzif https://github.com/pigozzif I've merged the PR, can you confirm it fixes your problem?

— Reply to this email directly, view it on GitHub https://github.com/google/evojax/issues/56#issuecomment-1360855588, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKOAOFLKJERIKHEWXENAKVDWOKECBANCNFSM6AAAAAATAC6CHY . You are receiving this because you were mentioned.Message ID: @.***>