search

google / exposure-notifications-server

Exposure Notification Reference Server | Covid-19 Exposure Notifications
https://www.google.com/covid19/exposurenotifications/
Apache License 2.0
2.46k stars 312 forks source link

using PathPrefix as a path catch-all so that v1alpha API works properly #1349

Closed bschlaman closed 3 years ago

bschlaman commented 3 years ago

Fixes #1348

Proposed Changes

Release Note

fixing exposure service handling of "/" path to fix v1alpha API
google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bschlaman To complete the pull request process, please assign yegle after the PR has been reviewed. You can assign the PR to them by writing /assign @yegle in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/google/exposure-notifications-server/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-robot commented 3 years ago

Hi @bschlaman. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
whaught commented 3 years ago

/ok-to-test

bschlaman commented 3 years ago

Closing for now, as I don't see evidence that urls besides "/" are actively being used in prod for v1alpha