Remove debugger_hosts and set default to [] to preserve backwards compatibility

google / exposure-notifications-server

Exposure Notification Reference Server | Covid-19 Exposure Notifications

https://www.google.com/covid19/exposurenotifications/

Apache License 2.0

2.46k stars 312 forks source link

Remove debugger_hosts and set default to [] to preserve backwards compatibility #1421

Closed sethvargo closed 3 years ago

sethvargo commented 3 years ago

The debugger service should never be publicly accessible and therefore doesn't need an uptime check. It's also not included in SLO calculations. Additionally, these new variables didn't have a default value, which makes them "required". This adds a default value of [] to preserve the backwards compatibility of the alerting module.

Release Note

NONE

/assign @mikehelmick /assign @mariliamelo

google-oss-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, sethvargo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/google/exposure-notifications-server/blob/main/OWNERS)~~ [mikehelmick,sethvargo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment