search

google / exposure-notifications-verification-server

Verification component for COVID-19 Exposure Notifications.
Apache License 2.0
234 stars 84 forks source link

Modeler tests have different results on ARM #2358

Closed mikehelmick closed 2 years ago

mikehelmick commented 2 years ago

TL;DR

One of the modeler tests has a different results on ARM (Apple M1) vs Intel processors.

--- FAIL: TestRebuildAbusePreventionModel (4.95s)
    modeler_test.go:160: expected 21 to be 22

Expected behavior

Math works the same everywhere

Observed behavior

Math doesn't work the same everywhere

Reproduction

go test ./...

Environment

Mac OS, M1 Pro processor

sethvargo commented 2 years ago

Interestingly, this returns 21 even in Rosetta (ARM operating in Intel mode): 

arch && go test -run TestRebuildAbusePreventionModel ./pkg/controller/modeler/...
i386

--- FAIL: TestRebuildAbusePreventionModel (0.68s)
    modeler_test.go:160: expected 21 to be 22
FAIL
FAIL    github.com/google/exposure-notifications-verification-server/pkg/controller/modeler 5.919s
FAIL
sethvargo commented 2 years ago

https://github.com/gonum/gonum/issues/1812