search

google / extra-keyboards-for-chrome-os

Extra keyboard layouts and input methods for Chrome OS
Apache License 2.0
201 stars 123 forks source link

Update options.js DOM text reinterpreted as HTML #137

Closed Shivam7-1 closed 6 months ago

Shivam7-1 commented 6 months ago

By using innerText, it will avoid the risk of HTML injection, as these properties automatically escape any HTML special characters in the provided text. This helps prevent cross-site scripting (XSS) vulnerabilities by treating the input as plain text rather than interpreted HTML.

Shivam7-1 commented 6 months ago

Hi @colmbuckley Could You Please Review This PR Thanks

Shivam7-1 commented 6 months ago

Hi @colmbuckley Thanks For Reviewing PR Is there anything Else is required From My side to get this PR merged? Thanks

colmbuckley commented 6 months ago

No, all good - I just forgot to merge it yesterday!

Colm

On Mon, 29 Apr 2024 at 04:05, Shivam7-1 @.***> wrote:

Hi @colmbuckley https://github.com/colmbuckley Thanks For Reviewing PR Is there anything Else is required From My side to get this PR merged? Thanks

— Reply to this email directly, view it on GitHub https://github.com/google/extra-keyboards-for-chrome-os/pull/137#issuecomment-2081814912, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMW5CVHIE6QIESSWI5BD7DY7W2JFAVCNFSM6AAAAABG5AXWMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBRHAYTIOJRGI . You are receiving this because you were mentioned.Message ID: @.***>

-- Colm Buckley | @.***