codecov-commenter
commented
2 months ago Codecov Report
Attention: Patch coverage is 5.26316% with 18 lines in your changes are missing coverage. Please review.
Project coverage is 50.39%. Comparing base (
8ffa8a3) to head (72a1dd8).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #1017 +/- ## ============================================ - Coverage 50.42% 50.39% -0.04% Complexity 666 666 ============================================ Files 91 91 Lines 5485 5487 +2 Branches 704 704 ============================================ - Hits 2766 2765 -1 - Misses 2459 2462 +3 Partials 260 260 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description of what I changed
Partially fixes #483; see this comment for details.
E2E test
TESTED:
Ran the controller locally and verified that the errors on the Thrift Server do not happen.
Checklist: I completed these to help reviewers :)
[x] I have read and will follow the review process.
[x] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
[x] My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
[ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
[x] I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit.[x] All new and existing tests passed.
[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master