Closed bashir2 closed 5 months ago
Attention: Patch coverage is 65.21739%
with 8 lines
in your changes are missing coverage. Please review.
Project coverage is 50.64%. Comparing base (
e80dd24
) to head (c454dfb
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Did not run, but changes make sense to me.
Great, thanks for the review.
Description of what I changed
This is related to this PR in sql-on-fhir-v2 repo. I had to remove FHIR version
3.0
from some of the tests for reasons discussed here.E2E test
TESTED:
Ran the tests locally and regenerated the report.
Checklist: I completed these to help reviewers :)
[x] I have read and will follow the review process.
[x] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
[x] My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
[x] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
[x] I ran
mvn clean package
right before creating this pull request and added all formatting changes to my commit.[x] All new and existing tests passed.
[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master