google / fhir-data-pipes

A collection of tools for extracting FHIR resources and analytics services on top of that data.
https://google.github.io/fhir-data-pipes/
Apache License 2.0
151 stars 84 forks source link

Added fhirVersion to SoFv2 tests and fixed report format #1033

Closed bashir2 closed 5 months ago

bashir2 commented 5 months ago

Description of what I changed

This is related to this PR in sql-on-fhir-v2 repo. I had to remove FHIR version 3.0 from some of the tests for reasons discussed here.

E2E test

TESTED:

Ran the tests locally and regenerated the report.

Checklist: I completed these to help reviewers :)

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 65.21739% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 50.64%. Comparing base (e80dd24) to head (c454dfb).

Files Patch % Lines
...com/google/fhir/analytics/view/ViewApplicator.java 66.66% 2 Missing and 2 partials :warning:
...com/google/fhir/analytics/view/ViewDefinition.java 63.63% 3 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1033 +/- ## ============================================ + Coverage 50.47% 50.64% +0.17% - Complexity 663 671 +8 ============================================ Files 91 91 Lines 5472 5483 +11 Branches 702 705 +3 ============================================ + Hits 2762 2777 +15 + Misses 2452 2446 -6 - Partials 258 260 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bashir2 commented 5 months ago

Did not run, but changes make sense to me.

Great, thanks for the review.