Closed bashir2 closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 50.64%. Comparing base (
bb80e8c
) to head (cd853a0
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
To have a record: This is the URL I used to check the test_report app.
@chandrashekar-s I am going to merge this once the e2e passes because I want to merge SoFv2 PR 235 which depends on this. This PR makes only test related formatting changes, so I think it is fine to merge without review; but please take a look and let me know if you have any comments to be applied later.
Description of what I changed
This is a follow-up to #1033.
E2E test
TESTED:
Ran the sql-on-fhir-v2 test_report app locally and tested the output.
Checklist: I completed these to help reviewers :)
[x] I have read and will follow the review process.
[x] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
[x] My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
[x] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
[x] I ran
mvn clean package
right before creating this pull request and added all formatting changes to my commit.[x] All new and existing tests passed.
[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master