google / fhir-data-pipes

A collection of tools for extracting FHIR resources and analytics services on top of that data.
https://google.github.io/fhir-data-pipes/
Apache License 2.0
141 stars 80 forks source link

Fixes SoFv2 test result format #1045

Closed bashir2 closed 2 months ago

bashir2 commented 2 months ago

Description of what I changed

This is a follow-up to #1033.

E2E test

TESTED:

Ran the sql-on-fhir-v2 test_report app locally and tested the output.

Checklist: I completed these to help reviewers :)

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.64%. Comparing base (bb80e8c) to head (cd853a0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1045 +/- ## ========================================= Coverage 50.64% 50.64% Complexity 671 671 ========================================= Files 91 91 Lines 5483 5483 Branches 705 705 ========================================= Hits 2777 2777 Misses 2446 2446 Partials 260 260 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bashir2 commented 2 months ago

To have a record: This is the URL I used to check the test_report app.

bashir2 commented 2 months ago

@chandrashekar-s I am going to merge this once the e2e passes because I want to merge SoFv2 PR 235 which depends on this. This PR makes only test related formatting changes, so I think it is fine to merge without review; but please take a look and let me know if you have any comments to be applied later.