google / fhir-data-pipes

A collection of tools for extracting FHIR resources and analytics services on top of that data.
https://google.github.io/fhir-data-pipes/
Apache License 2.0
141 stars 80 forks source link

Changes to fix issues of missing extensions and others #1050

Closed chandrashekar-s closed 1 month ago

chandrashekar-s commented 1 month ago

Description of what I changed

Fixes #1027 The below mentioned changes have been made as part of this PR

E2E test

TESTED:

Checklist: I completed these to help reviewers :)

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 50.60%. Comparing base (498d7c1) to head (bebc984).

Files Patch % Lines
.../bunsen/definitions/r4/R4StructureDefinitions.java 50.00% 2 Missing and 1 partial :warning:
...sen/definitions/stu3/Stu3StructureDefinitions.java 50.00% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1050 +/- ## ============================================ - Coverage 50.60% 50.60% -0.01% - Complexity 673 674 +1 ============================================ Files 91 91 Lines 5505 5511 +6 Branches 707 707 ============================================ + Hits 2786 2789 +3 - Misses 2457 2461 +4 + Partials 262 261 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chandrashekar-s commented 1 month ago

Hi @bashir2, thanks for the review. I have updated my comments and I have also created these 2 issues (Relook at the recursive depth and Fix the number of parquet files for DirectRunner) which can be resolved in different PRs.

chandrashekar-s commented 1 month ago

Thanks @bashir2 for the review, I have addressed the review comments and will be merging the PR. Please let me know if you see any discrepancies and I will take them up in a separate PR.