Closed chandrashekar-s closed 1 month ago
Attention: Patch coverage is 70.00000%
with 6 lines
in your changes are missing coverage. Please review.
Project coverage is 50.60%. Comparing base (
498d7c1
) to head (bebc984
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @bashir2, thanks for the review. I have updated my comments and I have also created these 2 issues (Relook at the recursive depth and Fix the number of parquet files for DirectRunner) which can be resolved in different PRs.
Thanks @bashir2 for the review, I have addressed the review comments and will be merging the PR. Please let me know if you see any discrepancies and I will take them up in a separate PR.
Description of what I changed
Fixes #1027 The below mentioned changes have been made as part of this PR
Decimal
data types.Reference
types have been changed to contain a full path name from root, so that it is unique for each path.E2E test
QuestionnaireResponse
fhir resource and ran aFull Run
and checked if theQuestionnaireResponse
is converted toAvro
record properlyTESTED:
Checklist: I completed these to help reviewers :)
[x] I have read and will follow the review process.
[x] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
[x] My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
[x] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
[x] I ran
mvn clean package
right before creating this pull request and added all formatting changes to my commit.[x] All new and existing tests passed.
[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master