Closed bashir2 closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 50.60%. Comparing base (
5eb81a2
) to head (2fe1dff
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description of what I changed
Fixes #1011 It also updates some deps/versions.
E2E test
TESTED:
Did a sample run with a S3 bucket for the output and verified the output files are created (note this needed
AWS_REGION
,AWS_SECRET_ACCESS_KEY
andAWS_ACCESS_KEY_ID
to be set):Checklist: I completed these to help reviewers :)
[x] I have read and will follow the review process.
[x] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
[x] My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
[ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
[x] I ran
mvn clean package
right before creating this pull request and added all formatting changes to my commit.[x] All new and existing tests passed.
[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master