search

google / fhir-data-pipes

A collection of tools for extracting FHIR resources and analytics services on top of that data.
https://google.github.io/fhir-data-pipes/
Apache License 2.0
157 stars 90 forks source link

Support Multiple Auth Types #587

Closed ageryck closed 1 year ago

ageryck commented 1 year ago

Pipeline to support multiple authentication types including OAuth2 and not only Basic Auth

bashir2 commented 1 year ago

Thanks for filing this. I think the basic idea for implementing OAuth2 support is to add a BearerTokenAuthInterceptor to the generic FHIR clients we create, e.g., here. We probably need to implement some extra support around refresh tokens.

@ageryck it would be helpful if you provide more details about how in your setup you fetch the initial OAuth token.

jjtswan commented 1 year ago

Still needs to be triaged - candidate for Beta.

bashir2 commented 1 year ago

@ageryck and @lincmba my understanding is that you have an implementation for this here. Is this something that you are willing to contribute to this repository too, such that everyone can benefit from it? I can work with you for the review process.

ageryck commented 1 year ago

@ageryck and @lincmba my understanding is that you have an implementation for this here. Is this something that you are willing to contribute to this repository too, such that everyone can benefit from it? I can work with you for the review process.

Yes @bashir2 we will make a PR and tag this issue as soon as @lincmba has permissions to push a PR

bashir2 commented 1 year ago

PR #670 is under review and it fixes #630 which removes the dependence of the JDBC mode on FHIR API. I believe with that fix, the priority of this issue will be lower.