bashir2
commented
10 months ago This is now obsolete because after merging #874 the e2e has been fixed. This is probably because that PR makes changes to the flink memory configuration parameters automatically, fixing the incremental build failures.
Description of what I changed
The e2e is failing since Nov. 24th in incremental run phase of step 12, i.e., testing the controller and thrift-server together. We don't get the log of the controller in Cloud Build logs (since we run it in detached mode). But from a local run it seems it fails in the merge step because of memory issues. Not sure why this might have been triggered now since PR #859 was merged more than a month ago. But anyways, reducing number of threads to see if that helps. (Note this is built on top of #887 so only the second commit belongs to this PR).
E2E test
TESTED:
Ran the incremental pipeline locally through the controller.
Checklist: I completed these to help reviewers :)
[x] I have read and will follow the review process.
[x] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
[x] My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
[ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
[x] I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit.[x] All new and existing tests passed.
[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master