Added FHIR Sink Config Properties to the Pipeline Controller

mozzy11 commented 5 months ago

Description of what I changed

Fixes https://github.com/google/fhir-data-pipes/issues/825

E2E test

Added Fhir Sink Config Properties to the Pipeline Controller to enable Synching data form a FHIR server to another FHIR server ie

fhirSinkPath: ""
  sinkUserName: "hapi"
  sinkPassword: "hapi123"

TESTED:

Successfully fetched data form OpenMRS to a HAPI FHIR server with both batch and incremental pipeleines

Checklist: I completed these to help reviewers :)

[x] I have read and will follow the review process.
[ ] I am familiar with Google Style Guides for the language I have coded in.

No? Please take some time and review Java and Python style guides.
[x] My IDE is configured to follow the Google code styles.

No? Unsure? -> configure your IDE.
[x] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
[x] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.
[x] All new and existing tests passed.
[x] My pull request is based on the latest changes of the master branch.

No? Unsure? -> execute command git pull --rebase upstream master

mozzy11 commented 5 months ago

@bashir2 ive looked at the Logs but it doesn't provide any detailed cause of the error

ERROR
ERROR: build step 14 "us-docker.pkg.dev/cloud-build-fhir/fhir-analytics/e2e-tests/controller-spark:31604b4" failed: step exited with non-zero status: 6

On following the Logs , The build breaks around here

The e2e tests run fine in my dev environment but I can't understand why it fails on CI .

mozzy11 commented 5 months ago

created a clean PR here https://github.com/google/fhir-data-pipes/pull/947

google / fhir-data-pipes