Closed bashir2 closed 8 months ago
Fixes #912 The error was that uuid was properly added in TYPE_TO_CONVERT map but missing from list of PRIMITIVE_TYPES. This PR also adds a unit-test to prevent similar discrepancies in the future.
uuid
TYPE_TO_CONVERT
PRIMITIVE_TYPES
TESTED:
Relied on the added unit tests and e2e tests.
[x] I have read and will follow the review process.
[x] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
[x] My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
[x] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
[x] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.
mvn clean package
[x] All new and existing tests passed.
[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command git pull --rebase upstream master
git pull --rebase upstream master
Description of what I changed
Fixes #912 The error was that
uuidwas properly added inTYPE_TO_CONVERTmap but missing from list ofPRIMITIVE_TYPES. This PR also adds a unit-test to prevent similar discrepancies in the future.E2E test
TESTED:
Relied on the added unit tests and e2e tests.
Checklist: I completed these to help reviewers :)
[x] I have read and will follow the review process.
[x] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
[x] My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
[x] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
[x] I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit.[x] All new and existing tests passed.
[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master