Upgrade hapi Fhir version to 7.2.1

chandrashekar-s commented 4 months ago

Description of what I changed

Upgraded HAPI FHIR Version to 7.0.0
Made the property name hapi.fhir.version to be same in both bunsen/pom.xml and pipelines/pom.xml files, so that dependabot upgrades the version in both the files simultaneously.
Added a dependency hapi-fhir-caching-caffeine, this was mandatory otherwise there was this below error being thrown

java.lang.RuntimeException: HAPI-2200: No Cache Service Providers found. Choose between hapi-fhir-caching-caffeine (Default) and hapi-fhir-caching-guava (Android)

    at ca.uhn.fhir.sl.cache.CacheFactory.getCacheProvider(CacheFactory.java:41)
    at ca.uhn.fhir.sl.cache.CacheFactory.build(CacheFactory.java:46)
    at org.hl7.fhir.r4.hapi.ctx.HapiWorkerContext.<init>(HapiWorkerContext.java:65)
    at org.hl7.fhir.r4.hapi.fluentpath.FhirPathR4.<init>(FhirPathR4.java:31)
    at com.google.fhir.analytics.view.ViewApplicator.<init>(ViewApplicator.java:66)
    at com.google.fhir.analytics.view.ViewApplicatorTest.applyViewOnResource(ViewApplicatorTest.java:72)
    at com.google.fhir.analytics.view.ViewApplicatorTest.emptyForEachOrNullWithUnion(ViewApplicatorTest.java:103)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

E2E test

Relied on E2E tests

TESTED:

Locally tested the full run.

Checklist: I completed these to help reviewers :)

[x] I have read and will follow the review process.
[x] I am familiar with Google Style Guides for the language I have coded in.

No? Please take some time and review Java and Python style guides.
[ ] My IDE is configured to follow the Google code styles.

No? Unsure? -> configure your IDE.
[ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
[x] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.
[ ] All new and existing tests passed.
[x] My pull request is based on the latest changes of the master branch.

No? Unsure? -> execute command git pull --rebase upstream master

chandrashekar-s commented 4 months ago

e2e tests are failing, will debug more on this.

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.92%. Comparing base (810687d) to head (627e21a).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #971 +/- ## ============================================ + Coverage 51.83% 51.92% +0.09% - Complexity 696 697 +1 ============================================ Files 91 91 Lines 5519 5519 Branches 709 709 ============================================ + Hits 2861 2866 +5 + Misses 2395 2390 -5 Partials 263 263 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chandrashekar-s commented 2 weeks ago

Hi @bashir2, this PR is ready for review, it contains changes for upgrading the HAPI library to 7.2.1

chandrashekar-s commented 2 weeks ago

Thanks @bashir2 for the review. I have addressed the review comments, will merge the changes once the build completes.

google / fhir-data-pipes