Closed chandrashekar-s closed 5 months ago
Attention: Patch coverage is 59.20578%
with 113 lines
in your changes are missing coverage. Please review.
Project coverage is 50.52%. Comparing base (
b354beb
) to head (178366b
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@bashir2 The PR is ready for the first round of review, can you please have a look and let me know if the approach taken is good. In the meanwhile, I will add unit tests.
@bashir2 Please have a look at the latest commits containing more unit tests and some minor fixes.
Thanks @bashir2 for the detailed review. I have addressed most of the comments, there are only 2 comments left which we can discuss in our tomorrow's meeting.
Description of what I changed
Fixes #980
This is an extension to the PR #924. In this PR we provide support for multiple FHIR profile extension for a given resource type. This is achieved by creating a Master AvroConverter for the given resource type by merging all the individual AvroConverters against the configured extensions profiles including the base profile. The merging includes a deep merge of the nested elements under the AvroConverter.
E2E test
Tested the changes with the default US Core FHIR profile extensions and verified that the extension fields are properly populated in the parquet files.
TESTED:
Please replace this with a description of how you tested your PR beyond the automated e2e/unit tests.
Checklist: I completed these to help reviewers :)
[x] I have read and will follow the review process.
[x] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
[x] My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
[ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
[x] I ran
mvn clean package
right before creating this pull request and added all formatting changes to my commit.[x] All new and existing tests passed.
[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master