codecov-commenter
commented
6 months ago Codecov Report
Attention: Patch coverage is 68.42105% with 6 lines in your changes are missing coverage. Please review.
Project coverage is 50.32%. Comparing base (
65cc128) to head (e750142).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #988 +/- ## ============================================ + Coverage 49.56% 50.32% +0.75% - Complexity 631 644 +13 ============================================ Files 87 87 Lines 5201 5210 +9 Branches 664 666 +2 ============================================ + Hits 2578 2622 +44 + Misses 2362 2339 -23 + Partials 261 249 -12 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description of what I changed
Fixes #954, barring some issues that need to be fixed/discussed in upstream repos (marked as
TODOs). As a side effect we get a nice increase on the test coverage of theviewpackage.E2E test
TESTED:
This is all about tests!
Checklist: I completed these to help reviewers :)
[x] I have read and will follow the review process.
[x] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
[x] My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
[x] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
[x] I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit.[x] All new and existing tests passed.
[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master